Skip to content

[#764] Close mobile nav on outside tap via backdrop overlay#767

Merged
realproject7 merged 1 commit intomainfrom
task/764-nav-close-outside
Apr 2, 2026
Merged

[#764] Close mobile nav on outside tap via backdrop overlay#767
realproject7 merged 1 commit intomainfrom
task/764-nav-close-outside

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Adds a fixed transparent backdrop (z-40, md:hidden) behind the mobile nav dropdown (z-50) when menu is open
  • Tapping the backdrop calls setMobileOpen(false) to dismiss the menu
  • Desktop layout unaffected (backdrop is md:hidden)

Fixes #764

Test plan

  • Mobile: tapping outside the menu closes it
  • Mobile: tapping menu links still works (navigates and closes)
  • Mobile: hamburger toggle still works
  • Desktop: no visible changes
  • npm run build passes

🤖 Generated with Claude Code

Renders a fixed transparent backdrop (z-40) behind the mobile dropdown
(z-50) when the menu is open. Tapping anywhere outside the menu
dismisses it. Only rendered on mobile (md:hidden).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored Apr 2, 2026 3:55pm

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T2b APPROVE

Clean backdrop overlay pattern. Transparent fixed inset-0 z-40 behind the z-50 dropdown, both gated on md:hidden. Tapping backdrop dismisses menu, tapping menu items still work due to z-index layering. No concerns.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

This PR adds the requested mobile backdrop overlay behind the nav dropdown so tapping outside the menu closes it, while keeping the existing desktop and in-menu behavior intact.

Findings

  • None.

Decision

Approving because the change is minimal, matches issue #764 directly, and the z-ordering keeps the dropdown above the backdrop as intended.

@realproject7 realproject7 merged commit b4e92cc into main Apr 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Mobile nav doesn't close when tapping page content

2 participants